Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support
Date	2016-10-21 17:50 +0200
Message-ID	<suKf0-7AT-41@gated-at.bofh.it> (permalink)
References	<suhcZ-5ak-3@gated-at.bofh.it> <suIdc-67f-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21 October 2016 at 19:09, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Thu, Oct 20, 2016 at 10:44 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> Hi,
>>
>> Some platforms (like TI) have complex DVFS configuration for CPU
>> devices, where multiple regulators are required to be configured to
>> change DVFS state of the device. This was explained well by Nishanth
>> earlier [1].
>>
>> Some thoughts went into it few months back but then it all got lost. I
>> am trying to get that back on track with this thread.
>>
>> One of the major complaints around multiple regulators case was that the
>> DT isn't responsible in any way to represent the ordering in which
>> multiple supplies need to be programmed, before or after frequency
>> change. It was considered in this patch and such information is left to
>> the platform specific OPP driver now, which can register its own
>> opp_set_rate() callback with the OPP core and the OPP core will then
>> call it during DVFS.
>>
>> The patches are tested on Exynos5250 (Dual A15). I have hacked around DT
>> and code to pass values for multiple regulators and verified that they
>> are all properly read by the kernel (using debugfs interface).
>>
>> Though more testing on real (TI) platforms would be useful.
>>
>> This is rebased over: linux-next branch in the PM tree.
>>
>> V1->V2:
>> - Ack from Rob for 1st patch
>> - Moved the supplies structure to pm_opp.h (Dave)
>> - Fixed an compilation warning.
>
> I need somebody from the OPP camp to review patches [2-8/8] for me.

Sure, I have already asked Stephen yesterday to do that.

--
viresh

Thread

[PATCH V2 0/8] PM / OPP: Multiple regulator support Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 10:50 +0200
  [PATCH V2 4/8] PM / OPP: Pass struct dev_pm_opp_supply to _set_opp_voltage() Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 10:50 +0200
    Re: [PATCH V2 4/8] PM / OPP: Pass struct dev_pm_opp_supply to  _set_opp_voltage() Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 01:20 +0200
      Re: [PATCH V2 4/8] PM / OPP: Pass struct dev_pm_opp_supply to  _set_opp_voltage() Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-25 05:50 +0200
        Re: [PATCH V2 4/8] PM / OPP: Pass struct dev_pm_opp_supply to  _set_opp_voltage() Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 22:30 +0200
          Re: [PATCH V2 4/8] PM / OPP: Pass struct dev_pm_opp_supply to  _set_opp_voltage() Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-26 05:40 +0200
  [PATCH V2 2/8] PM / OPP: Don't use OPP structure outside of rcu protected section Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 10:50 +0200
    Re: [PATCH V2 2/8] PM / OPP: Don't use OPP structure outside of rcu  protected section Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 01:00 +0200
      Re: [PATCH V2 2/8] PM / OPP: Don't use OPP structure outside of rcu  protected section Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-25 05:40 +0200
  [PATCH V2 6/8] PM / OPP: Separate out _generic_opp_set_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 10:50 +0200
    Re: [PATCH V2 6/8] PM / OPP: Separate out _generic_opp_set_rate() Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 21:00 +0200
      Re: [PATCH V2 6/8] PM / OPP: Separate out _generic_opp_set_rate() Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-26 08:10 +0200
  [PATCH V2 7/8] PM / OPP: Allow platform specific custom opp_set_rate() callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 10:50 +0200
    Re: [PATCH V2 7/8] PM / OPP: Allow platform specific custom  opp_set_rate() callbacks Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 21:10 +0200
      Re: [PATCH V2 7/8] PM / OPP: Allow platform specific custom  opp_set_rate() callbacks Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-26 08:10 +0200
  [PATCH V2 1/8] PM / OPP: Reword binding supporting multiple regulators per device Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-20 11:00 +0200
    Re: [PATCH V2 1/8] PM / OPP: Reword binding supporting multiple  regulators per device Stephen Boyd <sboyd@codeaurora.org> - 2016-10-25 00:50 +0200
  Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support "Rafael J. Wysocki" <rafael@kernel.org> - 2016-10-21 15:40 +0200
    Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-21 17:50 +0200
      Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support Dave Gerlach <d-gerlach@ti.com> - 2016-10-24 03:10 +0200
        Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-24 06:30 +0200
          Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support Dave Gerlach <d-gerlach@ti.com> - 2016-10-25 23:20 +0200
            Re: [PATCH V2 0/8] PM / OPP: Multiple regulator support Viresh Kumar <viresh.kumar@linaro.org> - 2016-10-26 05:30 +0200

csiph-web