Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support
Date	2016-10-21 15:40 +0200
Message-ID	<suIdc-67f-47@gated-at.bofh.it> (permalink)
References	<staQh-wi-5@gated-at.bofh.it> <staQh-wi-23@gated-at.bofh.it> <su4Su-5Dz-45@gated-at.bofh.it> <su806-7Cg-5@gated-at.bofh.it> <suq6B-2IT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-10-21 2:10 GMT+08:00 Radim Krčmář <rkrcmar@redhat.com>:
> 2016-10-20 06:57+0800, Wanpeng Li:
>> 2016-10-20 3:28 GMT+08:00 Radim Krčmář <rkrcmar@redhat.com>:
>>> I think it would be better to add a function to advance the periodic
>>> timer and use it in kvm_lapic_expired_hv_timer() and in apic_timer_fn().
>>>
>>> The function can be simpler than set_target_expiration(), because it
>>> just adds the period to an existing timer.  Periodic timer will also be
>>> better then, because the period will not depend on KVM's latency when
>>> rearming.
>>
>> Good point, what's the function name do you like? How about
>> advance_target_expiration()?
>
> Sounds good, I'd just slap periodic somewhere,
> advance_periodic_target_expiration()?

Cool, thanks for your review. :)

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX preemption timer support Wanpeng Li <kernellwp@gmail.com> - 2016-10-17 09:50 +0200
  Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX  preemption timer support Paolo Bonzini <pbonzini@redhat.com> - 2016-10-17 10:50 +0200
  Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX  preemption timer support Radim Krčmář <rkrcmar@redhat.com> - 2016-10-19 21:40 +0200
    Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX  preemption timer support Wanpeng Li <kernellwp@gmail.com> - 2016-10-20 01:00 +0200
      Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX  preemption timer support Radim Krčmář <rkrcmar@redhat.com> - 2016-10-20 20:20 +0200
        Re: [PATCH 5/5] KVM: LAPIC: add APIC Timer periodic/oneshot mode VMX  preemption timer support Wanpeng Li <kernellwp@gmail.com> - 2016-10-21 15:40 +0200

csiph-web