Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1504409

Re: [PATCH 2/3] thread_info: factor out restart_block

Show all headers | View raw

On Wed, Oct 19, 2016 at 11:28 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> Since commit f56141e3e2d9aabf ("all arches, signal: move restart_block
> to struct task_struct"), thread_info and restart_block have been
> logically distinct, yet struct restart_block is still defined in
> <linux/thread_info.h>.
>
> At least one architecture (erroneously) uses restart_block as part of
> its thread_info, and thus the definition of restart_block must come
> before the include of <asm/thread_info>. Subsequent patches in this
> series need to shuffle the order of includes and definitions in
> <linux/thread_info.h>, and will make this ordering fragile.
>
> This patch moves the definition of restart_block out to its own header.
> This serves as generic cleanup, logically separating thread_info and
> restart_block, and also makes it easier to avoid fragility.

Looks entirely reasonable to me.

Reviewed-by: Andy Lutomirski <luto@kernel.org>

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] thread_info: factor out restart_block Mark Rutland <mark.rutland@arm.com> - 2016-10-19 20:40 +0200
  Re: [PATCH 2/3] thread_info: factor out restart_block Andy Lutomirski <luto@amacapital.net> - 2016-10-20 01:40 +0200
    Re: [PATCH 2/3] thread_info: factor out restart_block Mark Rutland <mark.rutland@arm.com> - 2016-10-24 11:50 +0200

csiph-web