Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1503784
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/2] Add support for Omnivision OV5647 |
| Date | 2016-10-19 17:00 +0200 |
| Message-ID | <su0vx-2D0-45@gated-at.bofh.it> (permalink) |
| References | <srugq-6Lr-31@gated-at.bofh.it> <srugq-6Lr-39@gated-at.bofh.it> <stHsS-5Dk-35@gated-at.bofh.it> <su0vx-2D0-47@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi!
> >> +struct regval_list {
> >> + uint16_t addr;
> >> + uint8_t data;
> >> +};
> > u8/u16?
>
> This sensor uses 16 bits for addresses and 8 for data, so I think it makes sense
> to keep it this way.
Yes, you can do it. But please use u8/u16 types (also elsewhere in the
driver), they are more common in ther kernel.
> Thanks for the feedback. I agree with most of your suggestions, and I commented
> with the one I didn't agree.
You are welcome,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v3 2/2] Add support for Omnivision OV5647 Pavel Machek <pavel@ucw.cz> - 2016-10-18 20:40 +0200 Re: [PATCH v3 2/2] Add support for Omnivision OV5647 Pavel Machek <pavel@ucw.cz> - 2016-10-19 17:00 +0200 Re: [PATCH v3 2/2] Add support for Omnivision OV5647 Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> - 2016-10-19 17:00 +0200
csiph-web