[PATCH] NFSv4: Fix anonymous member initializer in update_open_stateid()

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	[PATCH] NFSv4: Fix anonymous member initializer in update_open_stateid()
Date	2016-10-17 12:20 +0200
Message-ID	<stdbs-2aY-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

With gcc 3.4/4.1/4.2/4.4/4.6/4.8:

    fs/nfs/nfs4proc.c: In function ‘update_open_stateid’:
    fs/nfs/nfs4proc.c:1548: warning: missing braces around initializer
    fs/nfs/nfs4proc.c:1548: warning: (near initialization for ‘freeme.<anonymous>’)

Add the missing braces to fix this.

Fixes: 1393d9612ba02d8b ("NFSv4: Fix a race when updating an open_stateid")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
See also commit e0714ec4f9efe7b8 ("nfs: fix anonymous member initializer
build failure with older compilers"). My first thought it was an old 4.x
thingy, but surprisingly this warning is also generated by gcc 4.8.4.
---
 fs/nfs/nfs4proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index ad917bd72b38c3b2..6fa34095783239da 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1545,7 +1545,7 @@ static int update_open_stateid(struct nfs4_state *state,
 	struct nfs_client *clp = server->nfs_client;
 	struct nfs_inode *nfsi = NFS_I(state->inode);
 	struct nfs_delegation *deleg_cur;
-	nfs4_stateid freeme = {0};
+	nfs4_stateid freeme = { { { 0 } } };
 	int ret = 0;
 
 	fmode &= (FMODE_READ|FMODE_WRITE);
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] NFSv4: Fix anonymous member initializer in update_open_stateid() Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-17 12:20 +0200

csiph-web