Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space
Date	2016-10-17 09:10 +0200
Message-ID	<stadA-j1-9@gated-at.bofh.it> (permalink)
References	<spkEy-3Bo-13@gated-at.bofh.it> <ssXgl-h3-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 16, 2016 at 10:17:53AM -0700, Andy Lutomirski wrote:
> On Thu, Oct 6, 2016 at 10:25 AM, Andy Lutomirski <luto@kernel.org> wrote:
> > Pointing an sg list at the stack is verboten and, with
> > CONFIG_VMAP_STACK=y, will malfunction.  Use kmalloc for the wusb
> > crypto stack space instead.
> >
> > Untested -- I'm not entirely convinced that this hardware exists in
> > the wild.
> 
> Greg, could you queue this up for 4.9?  I can't guarantee that it
> works, but I can pretty much guarantee that the driver is busted
> without it.

Yes, it's in my queue, couldn't do anything until after -rc1 came out.
I'll catch up on it this week.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space Andy Lutomirski <luto@amacapital.net> - 2016-10-16 19:20 +0200
  Re: [PATCH] wusb: Stop using the stack for sg crypto scratch space Greg KH <gregkh@linuxfoundation.org> - 2016-10-17 09:10 +0200

csiph-web