Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness()

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness()
Date	2016-10-19 06:00 +0200
Message-ID	<stQcN-3GM-1@gated-at.bofh.it> (permalink)
References	<stjAd-6l5-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 17, 2016 at 10:06:27AM -0700, Andy Lutomirski wrote:
> hw_random carefully avoids using a stack buffer except in
> add_early_randomness().  This causes a crash in virtio_rng if
> CONFIG_VMAP_STACK=y.
> 
> Reported-by: Matt Mullins <mmullins@mmlx.us>
> Tested-by: Matt Mullins <mmullins@mmlx.us>
> Fixes: d3cc7996473a ("hwrng: fetch randomness only after device init")
> Signed-off-by: Andy Lutomirski <luto@kernel.org>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Andy Lutomirski <luto@kernel.org> - 2016-10-17 19:10 +0200
  Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Stephan Mueller <smueller@chronox.de> - 2016-10-17 19:20 +0200
    Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Andy Lutomirski <luto@amacapital.net> - 2016-10-17 19:40 +0200
      Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Stephan Mueller <smueller@chronox.de> - 2016-10-17 20:40 +0200
        Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Andy Lutomirski <luto@amacapital.net> - 2016-10-17 23:10 +0200
          Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in add_early_randomness() Stephan Mueller <smueller@chronox.de> - 2016-10-17 23:20 +0200
  Re: [PATCH resend 4.9] hw_random: Don't use a stack buffer in  add_early_randomness() Herbert Xu <herbert@gondor.apana.org.au> - 2016-10-19 06:00 +0200

csiph-web