Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1500210

[PATCH 3/6] memstick: rtsx_usb_ms: Runtime resume the device when polling for cards

Show all headers | View raw

From: Alan Stern <stern@rowland.harvard.edu>

Accesses to the rtsx usb device, which is the parent of the rtsx memstick
device, must not be done unless it's runtime resumed.

Therefore when the rtsx_usb_ms driver polls for inserted memstick cards,
let's add pm_runtime_get|put*() to make sure accesses is done when the
rtsx usb device is runtime resumed.

Reported-by: Ritesh Raj Sarraf <rrs@researchut.com>
Tested-by: Ritesh Raj Sarraf <rrs@researchut.com>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/memstick/host/rtsx_usb_ms.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c
index d34bc35..1b99489 100644
--- a/drivers/memstick/host/rtsx_usb_ms.c
+++ b/drivers/memstick/host/rtsx_usb_ms.c
@@ -681,6 +681,7 @@ static int rtsx_usb_detect_ms_card(void *__host)
 	int err;
 
 	for (;;) {
+		pm_runtime_get_sync(ms_dev(host));
 		mutex_lock(&ucr->dev_mutex);
 
 		/* Check pending MS card changes */
@@ -703,6 +704,7 @@ static int rtsx_usb_detect_ms_card(void *__host)
 		}
 
 poll_again:
+		pm_runtime_put(ms_dev(host));
 		if (host->eject)
 			break;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:40 +0200
  [PATCH 4/6] memstick: rtsx_usb_ms: Manage runtime PM when accessing the device Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:40 +0200
  [PATCH 1/6] mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:40 +0200
  [PATCH 2/6] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing the led Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:40 +0200
  [PATCH 5/6] mmc: rtsx_usb_sdmmc: Enable runtime PM autosuspend Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:50 +0200
  [PATCH 6/6] mmc: core: Don't power off the card when starting the host Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:50 +0200
  [PATCH 3/6] memstick: rtsx_usb_ms: Runtime resume the device when polling for cards Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-13 13:50 +0200
  Re: [PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues Ulf Hansson <ulf.hansson@linaro.org> - 2016-10-17 16:00 +0200
    Re: [PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues Alan Stern <stern@rowland.harvard.edu> - 2016-10-17 18:40 +0200

csiph-web