Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board

From	Rahul Bedarkar <Rahul.Bedarkar@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board
Date	2016-10-13 09:30 +0200
Message-ID	<srICJ-rU-3@gated-at.bofh.it> (permalink)
References	<spg7T-6F-1@gated-at.bofh.it> <spg7T-6F-13@gated-at.bofh.it> <sqJKy-2la-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Monday 10 October 2016 07:51 PM, Rob Herring wrote:
>> +
>> +	memory {
>
> Is 0 the actual base, or that gets filled in by bootloader? If the
> formet, add unit address.
>

Bootloader (uboot) can override or fixup memory node. But with version 
of bootloader I tested with, base address is hardcoded to 0 and only 
size may get changed. But since booloader can override or fixup memory 
node, I assume we don't add unit address in this case.

>> +		device_type = "memory";
>> +		reg =  <0x00000000 0x08000000>;

I now realized that size is incorrectly specified in memory node. It 
should be 256MB and not 128MB. I will fix this in v2.

Thanks,
Rahul

Thread

[PATCH 1/2] MIPS: DTS: add base device tree for Pistachio SoC Rahul Bedarkar <rahul.bedarkar@imgtec.com> - 2016-10-06 14:40 +0200
  [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board Rahul Bedarkar <rahul.bedarkar@imgtec.com> - 2016-10-06 14:40 +0200
    Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board Rob Herring <robh@kernel.org> - 2016-10-10 16:30 +0200
      Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board Rahul Bedarkar <Rahul.Bedarkar@imgtec.com> - 2016-10-13 09:30 +0200
        RE: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board James Hartley <James.Hartley@imgtec.com> - 2016-10-13 10:50 +0200
          RE: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board James Hartley <James.Hartley@imgtec.com> - 2016-10-13 16:50 +0200

csiph-web