Re: pci_alloc_irq_vectors use in 8250_lpss.c

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: pci_alloc_irq_vectors use in 8250_lpss.c
Date	2016-10-10 00:30 +0200
Message-ID	<squLw-1ya-7@gated-at.bofh.it> (permalink)
References	<sqqyd-7eo-9@gated-at.bofh.it> <squsa-1oi-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Oct 10, 2016 at 1:01 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sun, Oct 9, 2016 at 8:56 PM, Christoph Hellwig <hch@lst.de> wrote:
>> Hi Andy,
>>
>> two comment on your ぱatch to add MSI support to the above driver.
>>
>> First pci_alloc_irq_vectors gained a mandatory flags argument, so
>> for MSI suport you now need to pass PCI_IRQ_MSI in flags for the
>> code to work.
>
> I will check this. Thanks for pointing to it.

Yeah, this has to be amended.

>
>>
>> Second please make sure to always pair pci_alloc_irq_vectors
>> with pci_free_irq_vectors on the remove path.
>
> For my opinion it should be done in PCI code since I'm using
> manageable resources. It's already done for all PCI API usually used
> at ->probe().

Nothing is required to do until you don't use some specific code. If
you plan extend *_free_*() function in the future, please, consider
manageable resources and automatic releasing.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

pci_alloc_irq_vectors use in 8250_lpss.c Christoph Hellwig <hch@lst.de> - 2016-10-09 20:00 +0200
  Re: pci_alloc_irq_vectors use in 8250_lpss.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-10 00:10 +0200
    Re: pci_alloc_irq_vectors use in 8250_lpss.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-10 00:30 +0200

csiph-web