Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs
Date	2016-10-09 19:10 +0200
Message-ID	<sqpLP-6Yo-3@gated-at.bofh.it> (permalink)
References	<smJSO-4KE-11@gated-at.bofh.it> <smJSO-4KE-9@gated-at.bofh.it> <spGOJ-3x4-17@gated-at.bofh.it> <sqnTI-5PK-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Oct 9, 2016 at 6:01 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Fri, Oct 07, 2016 at 08:05:14PM +0300, Andy Shevchenko wrote:
>> On Thu, Sep 29, 2016 at 4:39 PM, Mika Westerberg
>> <mika.westerberg@linux.intel.com> wrote:

>> > +       if (!chip->names)
>> > +               acpi_gpiochip_set_names(acpi_gpio);
>> > +
>>
>> I'm okay with this, though wouldn't be better to call it
>> unconditionally like it's done for below call and move check inside?
>
> DT does it like this. I can move the check inside the function as well.

Up to you. If it even worth to change.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-29 15:50 +0200
  Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-07 19:10 +0200
    Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-10-09 17:10 +0200
      Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-10-09 19:10 +0200

csiph-web