Re: [PATCH 2/3] pinctrl: berlin: Don't leak memory if krealloc() fails

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] pinctrl: berlin: Don't leak memory if krealloc() fails
Date	2016-10-10 10:50 +0200
Message-ID	<sqErw-7rt-15@gated-at.bofh.it> (permalink)
References	<sn4Xf-1Ge-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 30, 2016 at 2:13 PM, Johannes Thumshirn <jthumshirn@suse.de> wrote:

> We're directly assigning krealoc()'s return value to pctrl->functions instead
> of using a temporary value to handle error checking. This leaks memory in case
> krealloc() failes. While we're at it, implement error handling for failed
> allocations at all.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] pinctrl: berlin: Don't leak memory if krealloc() fails Johannes Thumshirn <jthumshirn@suse.de> - 2016-09-30 14:20 +0200
  Re: [PATCH 2/3] pinctrl: berlin: Don't leak memory if krealloc() fails Linus Walleij <linus.walleij@linaro.org> - 2016-10-10 10:50 +0200

csiph-web