Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1496987

Re: [PATCH] staging: lustre: lprocfs_status.h: fix sparse error: symbol redeclared with different type

Show all headers | View raw

On Thu, Oct 06, 2016 at 06:52:07PM +0200, Samuele Baisi wrote:
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1554:5: error:
> symbol 'lprocfs_wr_root_squash' redeclared with different type (originally
> declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:704)
> - incompatible argument 1 (different address spaces)
> 
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1618:5: error:
> symbol 'lprocfs_wr_nosquash_nids' redeclared with different type (originally
> declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:706)
> - incompatible argument 1 (different address spaces)
> 
> Added __user annotation to the header definitions arguments (which are
> indeed userspace buffers).

Are they really?  Have you tested this?  The last time this was looked
at, it was a non-trivial problem...

And any reason you didn't cc the lustre maintainers with this change?
If you think it is correct, please resend it with the testing
information and cc: them.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: lprocfs_status.h: fix sparse error: symbol redeclared with different type Samuele Baisi <ciccio87@gmail.com> - 2016-10-06 19:00 +0200
  Re: [PATCH] staging: lustre: lprocfs_status.h: fix sparse error:  symbol redeclared with different type Greg KH <gregkh@linuxfoundation.org> - 2016-10-07 06:10 +0200
    Re: [PATCH] staging: lustre: lprocfs_status.h: fix sparse error:  symbol redeclared with different type Samuele Baisi <ciccio87@gmail.com> - 2016-10-07 10:40 +0200

csiph-web