Re: [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA

From	Alexandre Torgue <alexandre.torgue@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA
Date	2016-10-06 16:10 +0200
Message-ID	<sphx0-18h-23@gated-at.bofh.it> (permalink)
References	<sphnk-Oy-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Geert,

On 10/06/2016 03:55 PM, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
>     drivers/built-in.o: In function `stm32_serial_remove':
>     stm32-usart.c:(.text+0xcea1a): undefined reference to `bad_dma_ops'
>     stm32-usart.c:(.text+0xcea7a): undefined reference to `bad_dma_ops'
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index c7831407a882d2bb..25c1d7bc010043b1 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1625,6 +1625,7 @@ config SERIAL_SPRD_CONSOLE
>  config SERIAL_STM32
>  	tristate "STMicroelectronics STM32 serial port support"
>  	select SERIAL_CORE
> +	depends on HAS_DMA
>  	depends on ARM || COMPILE_TEST
>  	help
>  	  This driver is for the on-chip Serial Controller on
>
I sent same kind of patch this morning (but mine have a bad copy paste).
I will abandon my patch.

However for this one:
Acked-by: Alexandre Torgue <alexandre.torgue@st.com>

regards
Alex

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serial: SERIAL_STM32 should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-10-06 16:00 +0200
  Re: [PATCH] serial: SERIAL_STM32 should depend on HAS_DMA Alexandre Torgue <alexandre.torgue@st.com> - 2016-10-06 16:10 +0200

csiph-web