Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1496593

Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

Show all headers | View raw

On 10/05/2016 07:03 AM, Mike Looijmans wrote:
> The KSZ9031 skew registers contain an offset, the chip's default value
> is "neutral" which does not add any skew. Programming a 0 into a skew
> property will actually set it the maximal negative adjustment and not
> to a neutral position as one would expect.
> 
> Explain this situation in the devicetree binding documentation and list
> the settings that the chip considers neutral.
> 
> Changing the implementation to accept negative values would have been
> a better solution, but would break existing configurations.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings Mike Looijmans <mike.looijmans@topic.nl> - 2016-10-05 16:10 +0200
  Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain  skew settings Florian Fainelli <f.fainelli@gmail.com> - 2016-10-06 13:10 +0200
  Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain  skew settings David Miller <davem@davemloft.net> - 2016-10-07 02:50 +0200

csiph-web