Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas

From	Moritz Fischer <moritz.fischer@ettus.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas
Date	2016-10-07 20:50 +0200
Message-ID	<spInw-4rh-19@gated-at.bofh.it> (permalink)
References	<spnCq-5Wo-9@gated-at.bofh.it> <spnCq-5Wo-5@gated-at.bofh.it> <sptot-1KA-7@gated-at.bofh.it> <spInw-4rh-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Alan,

On Fri, Oct 7, 2016 at 11:21 AM, atull <atull@opensource.altera.com> wrote:

> Moritz, Can you remind me what that issue was there (or point me to
> that email, I can't find it)?  I don't think I had a problem with that
> in your case.  In general I think if these drivers can take the
> bitstream that comes from the manufacturer's tools and stuff it into
> the FPGA, then we are accomplishing what we want.  So I am OK with
> this here.  The intent of the driver is to load a standard rbf, same
> as the other Altera FPGA drivers.

My first version of the zynq fpga manager had byte swapping in there
and detection of which format was used. Greg even (accidentially)
merged my initial code
which I then cleaned up in 4d10eaff5bfc69997a769f9c83b749f0a8c542fa
("fpga: zynq-fpga: Change fw format to handle bin instead of bit.") to
address the review
comments.

I do see your point about useability, and if this is something that
keeps coming up
we could pull that into the framework with a flag to SWAP or as part
of the image_information
struct.

Thoughts?

Cheers,

Moritz

[1] https://mail-archive.com/linux-kernel@vger.kernel.org/msg995245.html

Thread

[PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas Joshua Clayton <stillcompiling@gmail.com> - 2016-10-06 22:40 +0200
  [PATCH 3/3] ARM: dts: imx6q-evi: support cyclonespi Joshua Clayton <stillcompiling@gmail.com> - 2016-10-06 22:40 +0200
  Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas Moritz Fischer <moritz.fischer@ettus.com> - 2016-10-07 04:50 +0200
    Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas Moritz Fischer <moritz.fischer@ettus.com> - 2016-10-07 20:50 +0200
    Re: [PATCH 1/3] fpga manager: Add cyclonespi driver for Altera fpgas Joshua Clayton <stillcompiling@gmail.com> - 2016-10-07 23:00 +0200

csiph-web