Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1495485
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Use proper lock in fscache_objlist_config. |
| Date | 2016-10-04 17:50 +0200 |
| Message-ID | <soA8F-4HM-5@gated-at.bofh.it> (permalink) |
| References | <soy6R-3iO-15@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
Artem Savkov <asavkov@redhat.com> wrote: > fscache_objlist_config doesn't hold rkey->sem when calling user_key_payload, > that can result in a "suspicious RCU usage" warning. It does hold > rcu_read_lock, so it either needs to use unprotected rcu_dereference, > or take rkey->sem instead of rcu_read_lock. It shouldn't take key->sem. The RCU lock should be necessary as user_key_payload() wraps a call to rcu_dereference(). Did you encounter a lockdep report or did you visually inspect this? David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Use proper lock in fscache_objlist_config. Artem Savkov <asavkov@redhat.com> - 2016-10-04 15:40 +0200
Re: [PATCH] Use proper lock in fscache_objlist_config. David Howells <dhowells@redhat.com> - 2016-10-04 17:50 +0200
Re: [PATCH] Use proper lock in fscache_objlist_config. Artem Savkov <asavkov@redhat.com> - 2016-10-04 18:00 +0200
csiph-web