Re: [PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places
Date	2016-09-30 19:50 +0200
Message-ID	<sna6B-50L-15@gated-at.bofh.it> (permalink)
References	<smO66-7D0-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 29, 2016 at 07:14:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
> be more than 32 places, which leads to a 32 bit integer overflow. Fix this
> by using 1ULL instead of 1 before shifting it.  Also add braces on the
> for-loop to keep with coding style conventions.

Applied, thanks

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][V2] dmaengine: coh901318: fix integer overflow when shifting more than 32 places Colin King <colin.king@canonical.com> - 2016-09-29 20:20 +0200
  Re: [PATCH][V2] dmaengine: coh901318: fix integer overflow when  shifting more than 32 places Vinod Koul <vinod.koul@intel.com> - 2016-09-30 19:50 +0200

csiph-web