Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1493720

Re: [PATCH] mos7840: fix chars_in_buffer() return value

Show all headers | View raw

29.09.2016 13:09, Johan Hovold пишет:
> On Sat, Sep 24, 2016 at 06:00:57PM +0300, Stas Sergeev wrote:
>> The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on
>> a correct behaviour of that.
>> mos7840 implements it wrongly: if you write just one char, TIOCOUTQ
>> will return 32.
>> This patch should fix it by accounting the number of chars actually
>> written.
>> This patch, unfortunately, misses the Tested-by tag.
>> The reporter didn't test it, and I don't have the hardware in question.
> Why do you think the driver returns 32b in chars_in_buffer after writing
> a single character?
Hi Johan, this actually came from this ancient bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=45791
I was trying to add you back then and now, but your e-mail
doesn't seem to be registered in a bug tracker.
The code in question was different when I submitted the
original patch:
https://bugzilla.kernel.org/attachment.cgi?id=77241
Maybe the bug was since fixed.
In that case sorry for the noise.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mos7840: fix chars_in_buffer() return value Stas Sergeev <stsp@list.ru> - 2016-09-24 17:10 +0200
  Re: [PATCH] mos7840: fix chars_in_buffer() return value Johan Hovold <johan@kernel.org> - 2016-09-29 12:10 +0200
    Re: [PATCH] mos7840: fix chars_in_buffer() return value Stas Sergeev <stsp@list.ru> - 2016-09-29 23:10 +0200
      Re: [PATCH] mos7840: fix chars_in_buffer() return value Johan Hovold <johan@kernel.org> - 2016-09-30 13:10 +0200

csiph-web