Re: [PATCH] spmi: pmic-arb: Return an error code if sanity check fails

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] spmi: pmic-arb: Return an error code if sanity check fails
Date	2016-09-28 00:20 +0200
Message-ID	<sm8Tf-6PV-11@gated-at.bofh.it> (permalink)
References	<slKHg-8tj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/26, Christophe JAILLET wrote:
> If the test 'if (channel > 5)' is true, then we will return 'err' which
> is known to be 0 at this point.
> Return -EINVAL instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

Looks right, thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] spmi: pmic-arb: Return an error code if sanity check fails Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-09-26 22:30 +0200
  Re: [PATCH] spmi: pmic-arb: Return an error code if sanity check  fails Stephen Boyd <sboyd@codeaurora.org> - 2016-09-28 00:20 +0200

csiph-web