Re: [PATCH] net: hisilicon: mark symbols static where possible

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: hisilicon: mark symbols static where possible
Date	2016-09-26 08:30 +0200
Message-ID	<slxAm-h3-5@gated-at.bofh.it> (permalink)
References	<sldLj-4J9-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Baoyou Xie <baoyou.xie@linaro.org>
Date: Sun, 25 Sep 2016 17:16:44 +0800

> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes]
> 
> In fact, these two functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: hisilicon: mark symbols static where possible Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-25 11:20 +0200
  Re: [PATCH] net: hisilicon: mark symbols static where possible David Miller <davem@davemloft.net> - 2016-09-26 08:30 +0200

csiph-web