Re: [PATCH 3/6] isdn/hisax: add function declarations

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/6] isdn/hisax: add function declarations
Date	2016-09-26 01:40 +0200
Message-ID	<slrbz-4B9-3@gated-at.bofh.it> (permalink)
References	<skNHc-5m9-25@gated-at.bofh.it> <skQOJ-7dQ-7@gated-at.bofh.it> <slrbz-4B9-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sunday 25 September 2016, Baoyou Xie wrote:
> > > @@ -1350,3 +1350,63 @@ static inline struct pci_dev
> > *hisax_find_pci_device(unsigned int vendor,
> > >  }
> > >
> > >  #endif
> > > +
> > > +#if CARD_TELES3
> > > +int setup_teles3(struct IsdnCard *card);
> > > +#endif
> > > +
> > > +#if CARD_TELESPCI
> > > +int setup_telespci(struct IsdnCard *card);
> > > +#endif
> > > +
> >
> > When you add the declarations here, just leave out the #if guards,
> > and put all the declarations here unconditionally, as we normally
> > do in the kernel.
> >
> > oh, in this case, we can leave the declarations out the  #if guards.
> but I suggest we don't do that still, cause of some declarations used by
> function parameters may reply on the macro.

They all have the same 'struct IsdnCard' argument, which is already
visible (otherwise none of them would work).

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] isdn/hisax: add function declarations Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-24 07:30 +0200
  Re: [PATCH 3/6] isdn/hisax: add function declarations Arnd Bergmann <arnd@arndb.de> - 2016-09-24 10:50 +0200
    Re: [PATCH 3/6] isdn/hisax: add function declarations Arnd Bergmann <arnd@arndb.de> - 2016-09-26 01:40 +0200

csiph-web