Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1490921

[PATCH 0/3] ethernet: net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings

Show all headers | View raw

Some times ago, a serie of patches were committed :
- commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct net_device")
- commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api ethtool_{get|set}_link_ksettings")
The first patch add a regression on this driver, so it should be reverted.
As the second patch depend on the former, it should be reverted too.

The first patch is buggy because there is a "trick" in this driver.
The structure phydev is kept in the private data when the interface
go down, and used when the interface go up to enable the phy before
the function phy_connect is called.

I don't have this hardware, neither the datasheet. So I won't
update the driver to avoid this trick.

But the real goal of the first serie was to move to the new api
ethtool_{get|set}_link_ksettings. So I provide a new version of
the patch without the "cleaning" of driver to use the phydev
store in the net_device structure.

Jaedon Shin (1):
  Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

Philippe Reynes (2):
  Revert "net: ethernet: bcmgenet: use new api
    ethtool_{get|set}_link_ksettings"
  net: ethernet: broadcom: bcmgenet: use new api
    ethtool_{get|set}_link_ksettings

 drivers/net/ethernet/broadcom/genet/bcmgenet.c |   33 ++++++++++++-----------
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |    1 +
 drivers/net/ethernet/broadcom/genet/bcmmii.c   |   24 +++++++++--------
 3 files changed, 31 insertions(+), 27 deletions(-)

-- 
1.7.4.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ethernet: net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-09-25 17:40 +0200
  [PATCH 2/3] Revert "net: ethernet: bcmgenet: use phydev from struct net_device" Philippe Reynes <tremyfr@gmail.com> - 2016-09-25 17:40 +0200
  Re: [PATCH 0/3] ethernet: net: bcmgenet: only use new api  ethtool_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-09-25 18:00 +0200
  Re: [PATCH 0/3] ethernet: net: bcmgenet: only use new api  ethtool_{get|set}_link_ksettings Florian Fainelli <f.fainelli@gmail.com> - 2016-09-25 18:00 +0200

csiph-web