Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()
Date	2016-09-25 09:40 +0200
Message-ID	<slccy-3FL-9@gated-at.bofh.it> (permalink)
References	<skVv3-1Az-13@gated-at.bofh.it> <skVEJ-1DQ-1@gated-at.bofh.it> <skXQd-3em-5@gated-at.bofh.it> <slbTc-3zF-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 2016-09-25 at 09:15 +0200, SF Markus Elfring wrote:
> 1. Add a definition for the macros "MY_LOG_PREFIX" and "pr_fmt" so that
>    their information can be used for consistent message output.
> 
> 
> 2. Prefer usage of the macro "pr_info" over the interface "printk"
>    in this function.
> 
> 
> 3. Reduce number of output function calls.
> 
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> 
> 
> v2: Yesterday a software development discussion pointed weaknesses out around
>     the previous update steps "3" and "4".
>     Now I propose this update variant in the hope that my second approach
>     for this software module will work as desired and can be accepted
>     a bit easier.

No thank you.

This is not a good change as it messes with dmesg timestamps.

Simpler to read and more straightforward is multiple
individual function calls.

Thread

[PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 15:50 +0200
  [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info()  in joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 16:00 +0200
    Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() Joe Perches <joe@perches.com> - 2016-09-24 18:20 +0200
      Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-09-24 18:40 +0200
        Re: Input-gameport: Replace some printk() calls by pr_info() in  joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 19:30 +0200
      Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 18:40 +0200
        Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() Joe Perches <joe@perches.com> - 2016-09-24 18:50 +0200
          Re: Input-gameport: Replace some printk() calls by pr_info() in  joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 22:00 +0200
      Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-24 18:50 +0200
      [PATCH v2 3/3] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 09:20 +0200
        Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() Joe Perches <joe@perches.com> - 2016-09-25 09:40 +0200
          Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by  pr_info() in joydump_connect() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-25 09:50 +0200

csiph-web