Re: qemu:metag image runtime failure in -next due to 'kthread: allow to cancel kthread work'

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: qemu:metag image runtime failure in -next due to 'kthread: allow to cancel kthread work'
Date	2016-09-27 12:20 +0200
Message-ID	<slXEt-8j4-1@gated-at.bofh.it> (permalink)
References	(2 earlier) <si91v-1Sg-5@gated-at.bofh.it> <siaTE-37g-11@gated-at.bofh.it> <sj8d4-6Ib-27@gated-at.bofh.it> <sj8Zr-7eA-23@gated-at.bofh.it> <slXEt-8j4-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 27 September 2016 11:12:36 BST, Petr Mladek <pmladek@suse.com> wrote:
>On Mon 2016-09-19 08:45:09, Guenter Roeck wrote:
>> On Mon, Sep 19, 2016 at 03:55:29PM +0100, James Hogan wrote:
>> > On Sat, Sep 17, 2016 at 12:32:49AM +0100, James Hogan wrote:
>> > > Here this version of QEMU puts the args at where it thinks the
>end of
>> > > the loaded image is, which is based on the number of bytes copied
>from
>> > > the ELF, i.e. the total MemSiz's, not taking into account the
>alignment
>> > > gap in between, so it puts them at 0x40377348.
>> > 
>> > QEMU meta-v1.3.1 branch updated at:
>> > https://github.com/img-meta/qemu.git
>> > 
>> > Hopefully that'll fix it for you Guenter.
>> > 
>> Confirmed fixed.
>
>Could you please confirm that the boot problem has been fixed
>on the qemu side? I guess that it is
>https://github.com/img-meta/qemu/commit/0a2402860228198ae2729048f1de05aeedb7d642

Yes, that patch is sufficient.

>
>Could Andrew enable all the kthread worker API improvements in -mm
>tree again?
>
>I think that kthread worker patch has been an innocent victim.
>It added some functions that were not used anywhere. I think
>that it has triggered the boot problem just by chance.

Agreed, it altered the alignment of the sections enough to trigger linker generating multiple load program headers with a gap in between which confused qemu.

Cheers
James

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: qemu:metag image runtime failure in -next due to 'kthread: allow  to cancel kthread work' Petr Mladek <pmladek@suse.com> - 2016-09-27 12:20 +0200
  Re: qemu:metag image runtime failure in -next due to 'kthread: allow to cancel kthread work' James Hogan <james.hogan@imgtec.com> - 2016-09-27 12:20 +0200

csiph-web