Re: [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition
Date	2016-09-23 15:40 +0200
Message-ID	<skyRQ-4e3-13@gated-at.bofh.it> (permalink)
References	<skxsJ-3rG-3@gated-at.bofh.it> <skxCq-3yR-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Wolfram,


2016-09-23 21:12 GMT+09:00 Wolfram Sang <wsa@the-dreams.de>:
> On Fri, Sep 23, 2016 at 09:04:01PM +0900, Masahiro Yamada wrote:
>> Currently, the status register FI2C_SR is checked immediately after
>> a STOP condition is issued in case of the deferred STOP condition.
>> It takes typically 5-10 usec until the corresponding bits in the
>> register are set, so the error check for "stop condition was not
>> completed" is very likely to be false positive.
>>
>> Add wait code to relax the status register check.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Use readl_poll_timeout?
>

Yes, thanks for your advice!



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-23 14:10 +0200
  Re: [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP  condition Wolfram Sang <wsa@the-dreams.de> - 2016-09-23 14:20 +0200
    Re: [PATCH] i2c: uniphier-f: fix misdetection of incomplete STOP condition Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-09-23 15:40 +0200

csiph-web