Re: [PATCH 1/1] ARM: add printf format attribute to early_print()

From	Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] ARM: add printf format attribute to early_print()
Date	2016-09-24 14:40 +0200
Message-ID	<skUpj-Yr-7@gated-at.bofh.it> (permalink)
References	<sbbB8-4bC-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/08/16 18:58, Nicolas Iooss wrote:
> Adding such an attribute is helpful to detect errors related to printf
> formats at compile-time.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> ---
>  arch/arm/include/asm/setup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/setup.h b/arch/arm/include/asm/setup.h
> index 3613d7e9fc40..797b8505b49a 100644
> --- a/arch/arm/include/asm/setup.h
> +++ b/arch/arm/include/asm/setup.h
> @@ -22,7 +22,7 @@
>  static const struct tagtable __tagtable_##fn __tag = { tag, fn }
>  
>  extern int arm_add_memory(u64 start, u64 size);
> -extern void early_print(const char *str, ...);
> +extern __printf(1, 2) void early_print(const char *str, ...);
>  extern void dump_machine_table(void);
>  
>  #ifdef CONFIG_ATAGS_PROC

Hello,
I sent this patch a few weeks ago and got no reply (and nothing showed
up on https://patchwork.kernel.org/patch/9302825/). Could you please
consider it for 4.9?

Thanks,
Nicolas

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] ARM: add printf format attribute to early_print() Nicolas Iooss <nicolas.iooss_linux@m4x.org> - 2016-09-24 14:40 +0200

csiph-web