Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option

From	Keith Busch <keith.busch@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option
Date	2016-09-23 18:50 +0200
Message-ID	<skBPI-6j6-21@gated-at.bofh.it> (permalink)
References	<sgXvs-3zH-3@gated-at.bofh.it> <sgXvs-3zH-7@gated-at.bofh.it> <skzNT-4QO-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 23, 2016 at 09:34:41AM -0500, Bjorn Helgaas wrote:
> I made the necessary changes to match the renaming I did in the first
> patch, and I also used plain old "#ifdef" instead of "#if IS_ENABLED"
> since the rest of the file uses the former style.  If there's a reason
> to switch, we should change the whole file in a separate patch so we
> can explain the rationale.

The check was "IS_ENABLED" because VMD can be a loadable module, which
fails the ifdef check. I see Fengguang 0'dayed it using the module
configuration option. I can send you a fix based on your pci/hotplug
branch, or revert and apply the original patch if you prefer.

BTW, you had asked me not to split a series when incremental fixes
touched a single patch. I didn't resend the whole series here, and while
you got the right patches, I apologize for making it more difficult to find.

Thread

[PATCHv3 1/2] pciehp: Let user control LED status Keith Busch <keith.busch@intel.com> - 2016-09-13 17:10 +0200
  [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option Keith Busch <keith.busch@intel.com> - 2016-09-13 17:10 +0200
    Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option Bjorn Helgaas <helgaas@kernel.org> - 2016-09-23 16:40 +0200
      Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option Keith Busch <keith.busch@intel.com> - 2016-09-23 18:50 +0200
        Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option Bjorn Helgaas <helgaas@kernel.org> - 2016-09-23 21:20 +0200
          Re: [PATCHv3 2/2] x86/vmd: Add PCI domain specific LED option Keith Busch <keith.busch@intel.com> - 2016-09-24 00:10 +0200
  Re: [PATCHv3 1/2] pciehp: Let user control LED status kbuild test robot <lkp@intel.com> - 2016-09-13 17:30 +0200
  Re: [PATCHv3 1/2] pciehp: Let user control LED status Keith Busch <keith.busch@intel.com> - 2016-09-13 18:30 +0200

csiph-web