Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

From	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs
Date	2016-09-20 14:20 +0200
Message-ID	<sjsbL-2RR-11@gated-at.bofh.it> (permalink)
References	<sjmSJ-7Pm-3@gated-at.bofh.it> <sjmSJ-7Pm-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello.

On 9/20/2016 9:30 AM, Joel Stanley wrote:

> On Aspeed SoC with a direct PHY connection (non-NSCI), we receive
> continual PHYSTS interrupts:
>
>  [   20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>  [   20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>  [   20.280000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>  [   20.300000] ftgmac100 1e660000.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG
>
> This is because the driver was enabling low-level sensitive interrupt
> generation where the systems are wired for high-level. All CPU cycles
> are spent servicing this interrupt.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  drivers/net/ethernet/faraday/ftgmac100.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 7ba0f2d58a8b..5466df028381 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -223,6 +223,10 @@ static void ftgmac100_start_hw(struct ftgmac100 *priv, int speed)
>  {
>  	int maccr = MACCR_ENABLE_ALL;
>
> +	if (of_machine_is_compatible("aspeed,ast2500")) {
> +		maccr &= ~FTGMAC100_MACCR_PHY_LINK_LEVEL;
> +	}

    {} not needed here.

[...]

MBR, Sergei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs Joel Stanley <joel@jms.id.au> - 2016-09-20 08:40 +0200
  Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5  SoCs Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-09-20 14:20 +0200
    Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5  SoCs Andrew Lunn <andrew@lunn.ch> - 2016-09-20 17:30 +0200
      Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs Joel Stanley <joel@jms.id.au> - 2016-09-21 04:10 +0200
        Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5  SoCs Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-09-21 11:10 +0200
          Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs Joel Stanley <joel@jms.id.au> - 2016-09-21 11:20 +0200
            Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5  SoCs Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-09-21 12:50 +0200
  Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5  SoCs Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-20 14:20 +0200

csiph-web