Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1488119

Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

From khalasa@piap.pl (Krzysztof Hałasa)
Newsgroups linux.kernel
Subject Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)
Date 2016-09-21 15:30 +0200
Message-ID <sjPL4-146-5@gated-at.bofh.it> (permalink)
References <shEAp-7rV-5@gated-at.bofh.it> <shEK6-7vq-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hans Verkuil <hverkuil@xs4all.nl> writes:

> That was probably the reason for the pci_read_config_word in the reg_write
> code. Try putting that back (and just that).

Yes. I guess a single pci_read_config_word() would suffice.

Though it would obviously be much better to identify the place in the
driver which needs to have the write buffers flushed, and add a read()
just there.

The interrupt handler maybe (e.g. just before the return IRQ_HANDLED)?

OTOH this may be some sort of timing problem, I mean the faster code may
put too much stress on the SOLO chip.

Doesn't happen here so I can't test the cure.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey.utkin@corp.bluecherry.net> - 2016-09-15 15:10 +0200
  Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Hans Verkuil <hverkuil@xs4all.nl> - 2016-09-15 15:20 +0200
    Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Hans Verkuil <hverkuil@xs4all.nl> - 2016-09-15 15:30 +0200
    Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-15 15:30 +0200
      Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-09-15 16:00 +0200
    Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) khalasa@piap.pl (Krzysztof Hałasa) - 2016-09-21 15:30 +0200
      Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-21 15:50 +0200
        Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) khalasa@piap.pl (Krzysztof Hałasa) - 2016-09-22 11:00 +0200
          Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression) Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-22 17:30 +0200

csiph-web