Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486300

Re: [PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE

Show all headers | View raw

Hi Thomas,

On Mon, Sep 19, 2016 at 11:28 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 19 Sep 2016, Marc Zyngier wrote:
>> On 19/09/16 10:12, Thomas Gleixner wrote:
>> > On Mon, 19 Sep 2016, Marc Zyngier wrote:
>> >>    if (handle != handle_bad_irq && is_chained) {
>> >> +          unsigned int type = irqd_get_trigger_type(&desc->irq_data);
>> >> +
>> >>            /*
>> >>             * We're about to start this interrupt immediately,
>> >>             * hence the need to set the trigger configuration.
>> >> @@ -828,8 +830,10 @@ __irq_do_set_handler(struct irq_desc *desc, irq_flow_handler_t handle,
>> >>             * chained interrupt. Reset it immediately because we
>> >>             * do know better.
>> >>             */
>> >> -          __irq_set_trigger(desc, irqd_get_trigger_type(&desc->irq_data));
>> >> -          desc->handle_irq = handle;
>> >> +          if (type != IRQ_TYPE_NONE) {
>> >> +                  __irq_set_trigger(desc, type);
>> >> +                  desc->handle_irq = handle;
>> >
>> > Are you really sure that the handler should only be set when the trigger
>> > type is != NONE? I seriously doubt that this is correct.
>>
>> The handler has already been set outside of if() statement (at line
>> 819). Here, we only set it again if we've actually called
>> __irq_set_trigger() which could have changed it to something that takes
>> the type into account (handle_level_irq or handle_edge_irq, for example).
>
> Ah. I'll add a comment...

The comment is already there ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] genirq: Skip chained interrupt trigger configuration if type is IRQ_TYPE_NONE Marc Zyngier <marc.zyngier@arm.com> - 2016-09-19 11:00 +0200
  Re: [PATCH] genirq: Skip chained interrupt trigger configuration if  type is IRQ_TYPE_NONE Thomas Gleixner <tglx@linutronix.de> - 2016-09-19 11:20 +0200
    Re: [PATCH] genirq: Skip chained interrupt trigger configuration if  type is IRQ_TYPE_NONE Marc Zyngier <marc.zyngier@arm.com> - 2016-09-19 11:30 +0200
      Re: [PATCH] genirq: Skip chained interrupt trigger configuration if  type is IRQ_TYPE_NONE Thomas Gleixner <tglx@linutronix.de> - 2016-09-19 11:40 +0200
        Re: [PATCH] genirq: Skip chained interrupt trigger configuration if  type is IRQ_TYPE_NONE Thomas Gleixner <tglx@linutronix.de> - 2016-09-19 11:40 +0200
        Re: [PATCH] genirq: Skip chained interrupt trigger configuration if  type is IRQ_TYPE_NONE Geert Uytterhoeven <geert@linux-m68k.org> - 2016-09-19 11:40 +0200
  Re: [PATCH] genirq: Skip chained interrupt trigger configuration if  type is IRQ_TYPE_NONE Geert Uytterhoeven <geert@linux-m68k.org> - 2016-09-19 11:30 +0200
  [tip:irq/urgent] genirq: Skip chained interrupt trigger setup if  type is IRQ_TYPE_NONE tip-bot for Marc Zyngier <tipbot@zytor.com> - 2016-09-19 11:50 +0200
  [tip:irq/urgent] genirq: Skip chained interrupt trigger setup if  type is IRQ_TYPE_NONE tip-bot for Marc Zyngier <tipbot@zytor.com> - 2016-09-20 01:20 +0200
    Re: [tip:irq/urgent] genirq: Skip chained interrupt trigger setup  if type is IRQ_TYPE_NONE Thomas Gleixner <tglx@linutronix.de> - 2016-09-20 01:50 +0200

csiph-web