Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485544
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 02/24] ste_dma40: Return directly after a failed kmalloc_array() |
| Date | 2016-09-17 17:10 +0200 |
| Message-ID | <sippD-47m-15@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <sippD-47m-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 17 Sep 2016 08:21:30 +0200
Return directly after a memory allocation failed in this function
at the beginning.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/dma/ste_dma40.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index fbebeff..80a199a 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3412,10 +3412,8 @@ static int __init d40_lcla_allocate(struct d40_base *base)
page_list = kmalloc_array(MAX_LCLA_ALLOC_ATTEMPTS,
sizeof(*page_list),
GFP_KERNEL);
- if (!page_list) {
- ret = -ENOMEM;
- goto failure;
- }
+ if (!page_list)
+ return -ENOMEM;
/* Calculating how many pages that are required */
base->lcla_pool.pages = SZ_1K * base->num_phy_chans / PAGE_SIZE;
--
2.10.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/24] ste_dma40: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:10 +0200 [PATCH 01/24] ste_dma40: Use kmalloc_array() in d40_lcla_allocate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:10 +0200 [PATCH 02/24] ste_dma40: Return directly after a failed kmalloc_array() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:10 +0200 [PATCH 03/24] ste_dma40: Rename a jump label in d40_lcla_allocate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 06/24] ste_dma40: Replace four kzalloc() calls by kcalloc() in d40_hw_detect_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 08/24] ste_dma40: Less checks in d40_hw_detect_init() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 05/24] ste_dma40: Improve a size determination in d40_of_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 07/24] ste_dma40: Use kmalloc_array() in d40_hw_detect_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 04/24] ste_dma40: Move an assignment in d40_lcla_allocate() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 09/24] ste_dma40: Delete unnecessary variable initialisations in d40_hw_detect_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 10/24] ste_dma40: Adjust the position of a jump label in d40_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:20 +0200 [PATCH 12/24] ste_dma40: Rename jump labels in d40_dmaengine_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 17/24] ste_dma40: Move an assignment in d40_prep_desc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 14/24] ste_dma40: One check less in d40_prep_sg() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 16/24] ste_dma40: Rename a jump label in d40_prep_desc() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 11/24] ste_dma40: Rename a jump label in d40_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 13/24] ste_dma40: Rename a jump label in d40_alloc_chan_resources() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 15/24] ste_dma40: Move two assignments in d40_prep_sg() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:30 +0200 [PATCH 21/24] ste_dma40: Rename jump labels in d40_alloc_mask_set() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 [PATCH 18/24] ste_dma40: Rename a jump label in d40_is_paused() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 [PATCH 22/24] ste_dma40: Rename a jump label in dma_tasklet() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 [PATCH 20/24] ste_dma40: Rename a jump label in d40_alloc_mask_free() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 [PATCH 24/24] ste_dma40: Rename a jump label in d40_log_lli_to_lcxa() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 [PATCH 19/24] ste_dma40: Rename a jump label in d40_free_dma() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 [PATCH 23/24] ste_dma40: Rename a jump label in __d40_execute_command_phy() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-17 17:40 +0200 Re: [PATCH 00/24] ste_dma40: Fine-tuning for several function implementations Linus Walleij <linus.walleij@linaro.org> - 2016-09-23 11:50 +0200
csiph-web