Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h
Date	2016-09-18 22:40 +0200
Message-ID	<siR2z-4o4-41@gated-at.bofh.it> (permalink)
References	<siGqt-6js-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes]
> 
> In fact, these two functions are not declared in any file, but should
> be declared in a header file, thus can be recognized in other file.
> 
> So this patch adds the declarations into
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Why can't these be declared static?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: hns: add function declarations in hns_dsaf_mac.h Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 11:20 +0200
  Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h Arnd Bergmann <arnd@arndb.de> - 2016-09-18 22:40 +0200

csiph-web