Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices

From	Sam Van Den Berge <sam.van.den.berge@telenet.be>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices
Date	2016-09-18 20:20 +0200
Message-ID	<siOR3-35Q-3@gated-at.bofh.it> (permalink)
References	<shZbP-3TI-3@gated-at.bofh.it> <shKPv-2Mg-7@gated-at.bofh.it> <shZbP-3TI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 16, 2016 at 01:00:12PM +0200, Sylwester Nawrocki wrote:
> On 09/15/2016 09:41 PM, Sam Van Den Berge wrote:
> > @@ -445,10 +446,44 @@ static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = {
> >  	[DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
> >  };
> >  
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> > +	/* TODO: DMACH_XD0 */
> > +	/* TODO: DMACH_XD1 */
> > +	{ "3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
> 
> Thanks for the patch, still device name needs to be changed here
> to "s3c2440-sdi".

Thanks for spotting this! I guess I was too focused on the "rx-tx" part
that I totally missed the missing leading "s". I will fix this in v3.

Sam.

Thread

[PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices Sam Van Den Berge <sam.van.den.berge@telenet.be> - 2016-09-15 21:50 +0200
  Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440  devices Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-09-16 13:10 +0200
    Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440  devices Sam Van Den Berge <sam.van.den.berge@telenet.be> - 2016-09-18 20:20 +0200
  Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440  devices Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-16 13:20 +0200
    Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440  devices Sam Van Den Berge <sam.van.den.berge@telenet.be> - 2016-09-22 20:50 +0200

csiph-web