Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485078
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 02/18] UBI: fix add_fastmap() to use the vid_hdr passed in argument |
| Date | 2016-09-16 17:00 +0200 |
| Message-ID | <si2Mp-63M-5@gated-at.bofh.it> (permalink) |
| References | <si2Mp-63M-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
add_fastmap() is passed a ubi_vid_hdr pointer in argument, but is referencing the global vidh pointer. Even if this is correct from a functional point of view (vidh and vid_hdr point to the same object), it is confusing. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> --- drivers/mtd/ubi/attach.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c index 903becd31410..95138ae2062f 100644 --- a/drivers/mtd/ubi/attach.c +++ b/drivers/mtd/ubi/attach.c @@ -197,8 +197,8 @@ static int add_fastmap(struct ubi_attach_info *ai, int pnum, return -ENOMEM; aeb->pnum = pnum; - aeb->vol_id = be32_to_cpu(vidh->vol_id); - aeb->sqnum = be64_to_cpu(vidh->sqnum); + aeb->vol_id = be32_to_cpu(vid_hdr->vol_id); + aeb->sqnum = be64_to_cpu(vid_hdr->sqnum); aeb->ec = ec; list_add(&aeb->u.list, &ai->fastmap); -- 2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH v3 02/18] UBI: fix add_fastmap() to use the vid_hdr passed in argument Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-09-16 17:00 +0200
csiph-web