Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > comp.lang.c > #162571
| From | Andrey Tarasevich <andreytarasevich@hotmail.com> |
|---|---|
| Newsgroups | comp.lang.c |
| Subject | Re: Working code |
| Date | 2021-09-01 21:02 -0700 |
| Organization | A noiseless patient Spider |
| Message-ID | <sgpic7$n6p$1@dont-email.me> (permalink) |
| References | <sgouhf$8i2$1@z-news.wcss.wroc.pl> |
On 9/1/2021 3:23 PM, antispam@math.uni.wroc.pl wrote: > > I wonder what you think about this code? > The macro is idiotically named: `DO_IT`? Seriously? The reliance on the caller-provided local variable `p` doesn't make much sense. Why would they even need an intermediate variable? Bitwise operator is applied to a signed type - that doesn't look good. Can't say more since it depends on the semantics of the values involved. Other than that the code looks fine. -- Best regards, Andrey Tarasevich
Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Working code antispam@math.uni.wroc.pl - 2021-09-01 22:23 +0000
Re: Working code Tim Rentsch <tr.17687@z991.linuxsc.com> - 2021-09-01 16:58 -0700
Re: Working code Andrey Tarasevich <andreytarasevich@hotmail.com> - 2021-09-01 20:57 -0700
Re: Working code Ike Naar <ike@rie.sdf.org> - 2021-09-02 05:22 +0000
Re: Working code Andrey Tarasevich <andreytarasevich@hotmail.com> - 2021-09-01 22:33 -0700
Re: Working code Ben Bacarisse <ben.usenet@bsb.me.uk> - 2021-09-02 11:54 +0100
Re: Working code Richard Damon <Richard@Damon-Family.org> - 2021-09-02 07:08 -0400
Re: Working code Ben Bacarisse <ben.usenet@bsb.me.uk> - 2021-09-02 13:37 +0100
Re: Working code James Kuyper <jameskuyper@alumni.caltech.edu> - 2021-09-02 12:03 -0400
Re: Working code Tim Rentsch <tr.17687@z991.linuxsc.com> - 2021-09-02 09:57 -0700
Re: Working code Andrey Tarasevich <andreytarasevich@hotmail.com> - 2021-09-01 21:02 -0700
Re: Working code John McCue <jmccue@obsd2.mhome.org> - 2021-09-02 13:31 +0000
csiph-web