Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482282

[PATCH 3/3] virtio_scsi: use complete() instead complete_all()

From Daniel Wagner <wagi@monom.org>
Newsgroups linux.kernel
Subject [PATCH 3/3] virtio_scsi: use complete() instead complete_all()
Date 2016-09-13 11:00 +0200
Message-ID <sgRJp-7Xu-53@gated-at.bofh.it> (permalink)
References <sgRJo-7Xu-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: Daniel Wagner <daniel.wagner@bmw-carit.de>

There is only one waiter for the completion, therefore there is no need
to use complete_all(). Let's make that clear by using complete() instead
of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

virtscsi_tmf()
  DECLARE_COMPLETION_ONSTACK()
  virtscsi_kick_cmd()
  wait_for_completion()

                                        virtscsi_complete_free()
                                          complete()

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
---
 drivers/scsi/virtio_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 7dbbb29..86924ff 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -258,7 +258,7 @@ static void virtscsi_complete_free(struct virtio_scsi *vscsi, void *buf)
 	struct virtio_scsi_cmd *cmd = buf;
 
 	if (cmd->comp)
-		complete_all(cmd->comp);
+		complete(cmd->comp);
 }
 
 static void virtscsi_ctrl_done(struct virtqueue *vq)
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] wireless: Use complete() instead complete_all() Daniel Wagner <wagi@monom.org> - 2016-09-13 11:00 +0200
  [PATCH 1/3] csiostor: fix completion usage Daniel Wagner <wagi@monom.org> - 2016-09-13 11:00 +0200
    Re: [PATCH 1/3] csiostor: fix completion usage Christoph Hellwig <hch@infradead.org> - 2016-09-14 09:30 +0200
  [PATCH 2/3] sym53c8xx_2: use complete() instead complete_all() Daniel Wagner <wagi@monom.org> - 2016-09-13 11:00 +0200
  [PATCH 3/3] virtio_scsi: use complete() instead complete_all() Daniel Wagner <wagi@monom.org> - 2016-09-13 11:00 +0200
    Re: [PATCH 3/3] virtio_scsi: use complete() instead complete_all() Christoph Hellwig <hch@infradead.org> - 2016-09-14 09:30 +0200
  Re: [PATCH 0/3] wireless: Use complete() instead complete_all() "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-09-14 19:30 +0200

csiph-web