Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482244

Re: [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl

Show all headers | View raw

On Fri, Sep 9, 2016 at 4:42 PM, Alexandre TORGUE
<alexandre.torgue@st.com> wrote:

> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> index 587bffb..a0eed99 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> @@ -14,6 +14,9 @@ Required properies:
>   - #size-cells : The value of this property must be 1
>   - ranges      : defines mapping between pin controller node (parent) to
>     gpio-bank node (children).
> + - interrupt-parent: phandle of the interrupt parent to which the external
> +   GPIO interrupts are forwarded to.
> + - st,syscfg: phandle of the syscfg node used for IRQ mux selection.

Actually this doc is incomplete.

This is a phandle + offset, not just a phandle.

It is a small detail so I don't care much, either send a patch to
fix up this doc (I have already merged it) or patch the driver
to not retrieve the offset and instead use
#define SYSCFG_OFFSET 0x08
or something...

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/9] Add STM32 EXTI interrupt controller support Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
  [PATCH v5 7/9] ARM: dts: Add GPIO irq support to STM2F429 Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
  [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
    Re: [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related  properties of STM32 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 10:20 +0200
    Re: [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related  properties of STM32 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 10:20 +0200
      Re: [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related  properties of STM32 pinctrl Alexandre Torgue <alexandre.torgue@st.com> - 2016-09-13 14:40 +0200
        Re: [PATCH v5 5/9] Documentation: dt-bindings: Add IRQ related  properties of STM32 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 14:50 +0200
  [PATCH v5 8/9] ARM: dts: Declare push button as GPIO key on stm32f429 boards Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
  [PATCH v5 3/9] ARM: STM32: Select external interrupts controller Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
  [PATCH v5 9/9] ARM: config: Enable GPIO Key driver in stm32_defconfig Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
  [PATCH v5 4/9] ARM: dts: Add EXTI controller node to stm32f429 Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
  [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios Alexandre TORGUE <alexandre.torgue@st.com> - 2016-09-09 16:50 +0200
    Re: [PATCH v5 6/9] pinctrl: Add IRQ support to STM32 gpios Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 10:20 +0200

csiph-web