Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482158
| From | Carlo Caione <carlo@caione.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X |
| Date | 2016-09-13 08:20 +0200 |
| Message-ID | <sgPex-6r3-1@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <sdeuS-2Qj-17@gated-at.bofh.it> <sgChj-5GQ-11@gated-at.bofh.it> <sgD3K-6fr-103@gated-at.bofh.it> <sgGkV-8vM-11@gated-at.bofh.it> <sgHh0-K3-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Sep 12, 2016 at 11:43 PM, Andreas Färber <afaerber@suse.de> wrote: [cut] > I'm not arguing over the file name, where it perfectly makes sense to > have a meson-gxl- prefix (already discussed), just about the compatible > string where we don't have "amlogic,meson-gxl-s905x-p231" either because > it is completely unnecessary and does _not_ add any value. > > Not that we're checking this string anywhere anyway... If you want to > check for the GXL family you have to use "amlogic,meson-gxl"; if you > want to check for the specific SoC you use "amlogic,s905x". Simple. We > never match partial strings, so there is no sense in a hardcoded prefix > that is duplicating information already available. Ok, then. Fine with me. Neil, do you want to resend my patch or you can take care of the fixes for the whole patchset? Thanks, -- Carlo Caione
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Andreas Färber <afaerber@suse.de> - 2016-09-12 18:30 +0200
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Carlo Caione <carlo@caione.org> - 2016-09-12 19:20 +0200
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Kevin Hilman <khilman@baylibre.com> - 2016-09-12 22:50 +0200
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Andreas Färber <afaerber@suse.de> - 2016-09-12 23:50 +0200
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Kevin Hilman <khilman@baylibre.com> - 2016-09-13 06:50 +0200
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Carlo Caione <carlo@caione.org> - 2016-09-13 08:20 +0200
Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X Neil Armstrong <narmstrong@baylibre.com> - 2016-09-13 09:40 +0200
csiph-web