Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482177

Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Sep 09, 2016 at 06:30:41PM +0800, Salil Mehta wrote:
> From: Lijun Ou <oulijun@huawei.com>
>
> This lock will be used in query port interface, and will be called
> while IB device was registered to OFED frame. So, the lock of iboe
> must be initiated before IB device was registered.

Sorry,
what did you mean by writing "OFED frame"?

>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> Signed-off-by: Dongdong Huang(Donald) <hdd.huang@huawei.com>
> Reviewed-by:  Wei Hu (Xavier) <xavier.huwei@huawei.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_main.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
> index 2704076..4721c0c 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_main.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_main.c
> @@ -615,6 +615,7 @@ static int hns_roce_register_device(struct hns_roce_dev *hr_dev)
>  	struct device *dev = &hr_dev->pdev->dev;
>
>  	iboe = &hr_dev->iboe;
> +	spin_lock_init(&iboe->lock);
>
>  	ib_dev = &hr_dev->ib_dev;
>  	strlcpy(ib_dev->name, "hisi_%d", IB_DEVICE_NAME_MAX);
> @@ -701,8 +702,6 @@ static int hns_roce_register_device(struct hns_roce_dev *hr_dev)
>  		goto error_failed_setup_mtu_gids;
>  	}
>
> -	spin_lock_init(&iboe->lock);
> -
>  	iboe->nb.notifier_call = hns_roce_netdev_event;
>  	ret = register_netdevice_notifier(&iboe->nb);
>  	if (ret) {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock Leon Romanovsky <leon@kernel.org> - 2016-09-13 09:00 +0200
  RE: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock Salil Mehta <salil.mehta@huawei.com> - 2016-09-14 04:20 +0200
    Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock Leon Romanovsky <leon@kernel.org> - 2016-09-14 07:10 +0200
      RE: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock Salil Mehta <salil.mehta@huawei.com> - 2016-09-15 06:00 +0200

csiph-web