Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481793

Re: [PATCH] staging: rtl8712: fix coding style error reported from checkpatch

Show all headers | View raw

On Mon, 2016-09-12 at 21:02 +0300, Omri Arad wrote:
[]
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
[]
> @@ -1976,9 +1976,9 @@ static int r871x_get_ap_info(struct net_device *dev,
>  	if (pdata->length >= 32) {
>  		if (copy_from_user(data, pdata->pointer, 32))
>  			return -EINVAL;
> -                data[32] = 0;
> +		data[32] = 0;
>  	} else {
> -		 return -EINVAL;
> +		return -EINVAL;
>  	}
>  	spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL);
>  	phead = &queue->queue;

Please don't blindly follow checkpatch messages but look to see
how the code can be improved beyond what checkpatch emits.

Perhaps more pleasant to read would be to rewrite this block like:

	if (pdata->length < 32 ||
	    copy_from_user(data, pdata->pointer, 32))
		return -EINVAL;
	data[32] = 0;

Perhaps as well the literal 32 uses here and the 33 in the declaration
of data uses should be some #define or sizeof or ARRAY_SIZE.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8712: fix coding style error reported from checkpatch Omri Arad <omriarad3@gmail.com> - 2016-09-12 20:10 +0200
  Re: [PATCH] staging: rtl8712: fix coding style error reported from  checkpatch Joe Perches <joe@perches.com> - 2016-09-12 20:20 +0200

csiph-web