Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1479704
| From | Richard Leitner <dev@g0hl1n.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls |
| Date | 2016-09-09 09:50 +0200 |
| Message-ID | <sfoJs-8tz-3@gated-at.bofh.it> (permalink) |
| References | <sbXZ8-1kH-5@gated-at.bofh.it> <sc889-7Pb-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
any comments, updates or ideas for improvement on that patch?
regards,
Richard
On Wed, 31 Aug 2016 09:26:31 +0200
Richard Leitner <dev@g0hl1n.net> wrote:
> These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000
> using its CHIP_ANA_CTRL register.
>
> Signed-off-by: Richard Leitner <dev@g0hl1n.net>
> ---
> CHANGES v2: fix invert value for both controls
> (sorry I've missed that in my initial tests!)
> ---
> sound/soc/codecs/sgtl5000.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 527b759..a6af65d 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -411,6 +411,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
> 0, 8,
> 0x7f, 1,
> headphone_volume),
> + SOC_SINGLE("Headphone Playback Switch", SGTL5000_CHIP_ANA_CTRL,
> + 4, 1, 1),
> SOC_SINGLE("Headphone Playback ZC Switch", SGTL5000_CHIP_ANA_CTRL,
> 5, 1, 0),
>
> @@ -423,6 +425,7 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
> SGTL5000_LINE_OUT_VOL_RIGHT_SHIFT,
> 0x1f, 1,
> lineout_volume),
> + SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
> };
>
> /* mute the codec used by alsa core */
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ASoC: sgtl5000: add headphone and LINEOUT mute controls Richard Leitner <dev@g0hl1n.net> - 2016-08-30 22:40 +0200
[PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls Richard Leitner <dev@g0hl1n.net> - 2016-08-31 09:30 +0200
Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls Richard Leitner <dev@g0hl1n.net> - 2016-09-09 09:50 +0200
Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls Mark Brown <broonie@kernel.org> - 2016-09-09 12:20 +0200
csiph-web