RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes

From	Matthew Wilcox <mawilcox@microsoft.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes
Date	2016-09-10 18:00 +0200
Message-ID	<sfSRc-252-5@gated-at.bofh.it> (permalink)
References	(4 earlier) <sbpNM-4Om-31@gated-at.bofh.it> <sbukq-7qb-19@gated-at.bofh.it> <sfxa2-5qO-11@gated-at.bofh.it> <sfAKB-7F8-1@gated-at.bofh.it> <sfL3j-5DY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Christoph Hellwig [mailto:hch@infradead.org]
> Either way we need to get rid of buffer_heads, and another aop that is entirely
> caller specific is unaceptable.

I finally figured out what you actually meant by this.  You mean that instead of having an aop->populate_pfn, you want to define a populate_pfn_t callback and pass it in.

Something like this:

int ext2_populate_pfn(struct address_space *mapping, pgoff_t pgoff)
{
	struct iomap iomap;
	...
	return dax_populate_pfn(mapping, pgoff, &iomap);
}

int ext2_dax_fault(vma, vmf)
{
	...
	ret = dax_fault(vma, vmf, ext2_populate_pfn);
	...
}

I don't have a problem with that.  I'll work up something along those lines next week.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-09-09 18:50 +0200
  RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-09 22:40 +0200
    Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Dan Williams <dan.j.williams@intel.com> - 2016-09-10 00:40 +0200
      Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Christoph Hellwig <hch@infradead.org> - 2016-09-10 09:40 +0200
        RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-10 10:00 +0200
        Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Theodore Ts'o <tytso@mit.edu> - 2016-09-10 20:00 +0200
          RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-11 02:50 +0200
      RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-10 10:20 +0200
        Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Dan Williams <dan.j.williams@intel.com> - 2016-09-10 17:00 +0200
    Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Christoph Hellwig <hch@infradead.org> - 2016-09-10 09:40 +0200
      RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-10 09:40 +0200
        Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Christoph Hellwig <hch@infradead.org> - 2016-09-10 09:50 +0200
          RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-10 10:00 +0200
            Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Christoph Hellwig <hch@infradead.org> - 2016-09-11 14:50 +0200
              Re: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-09-12 01:00 +0200
      RE: [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-10 18:00 +0200

csiph-web