Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480450

Re: [PATCH 2/5] dax: fix offset to physical address translation

Show all headers | View raw

On Tue, Sep 6, 2016 at 9:49 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> In pgoff_to_phys() 'pgoff' is already relative to base of the dax
> device, so we only need to compare if the current offset is within the
> current resource extent.  Otherwise, we are double accounting the
> resource start offset when translating pgoff to a physical address.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

On second look this results in the exact same translation, correct in
both cases.  This is also confirmed by a new ndctl unit test that does
data verification by writing through a /dev/pmem device and the
verifying via a /dev/dax device associated with the same namespace, so
I'm dropping this patch.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] device-dax and huge-page dax fixes for 4.8-rc6 Dan Williams <dan.j.williams@intel.com> - 2016-09-06 19:00 +0200
  [PATCH 2/5] dax: fix offset to physical address translation Dan Williams <dan.j.williams@intel.com> - 2016-09-06 19:00 +0200
    Re: [PATCH 2/5] dax: fix offset to physical address translation Dan Williams <dan.j.williams@intel.com> - 2016-09-10 03:10 +0200
  [PATCH 1/5] dax: fix mapping size check Dan Williams <dan.j.williams@intel.com> - 2016-09-06 19:00 +0200

csiph-web