lsl / lsr possible confusion in v7_flush_dcache_all

From	Vincent Siles <vincent.siles@provenrun.com>
Newsgroups	linux.kernel
Subject	lsl / lsr possible confusion in v7_flush_dcache_all
Date	2016-09-08 11:40 +0200
Message-ID	<sf3Yl-417-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi !
While reading the v7_flush_dcache_all (arch/arm/mm/cache-v7.S), I
stumbled upon this line:

# r10 is the current cache level
127: add    r2, r10, r10, lsr #1	    @ work out 3x current cache level

If we want r2 to be 3 * r10, we should compute r10 + (r10 << 1), which
is lsl, not lsr.

I check for a recent kernel, the issue seems to still be here:
repo:       git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
revision:   d71f058617564750261b673ea9b3352382b9cde4

Best regards,
Vincent Siles

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

lsl / lsr possible confusion in v7_flush_dcache_all Vincent Siles <vincent.siles@provenrun.com> - 2016-09-08 11:40 +0200
  Re: lsl / lsr possible confusion in v7_flush_dcache_all Will Deacon <will.deacon@arm.com> - 2016-09-08 11:40 +0200
    Re: lsl / lsr possible confusion in v7_flush_dcache_all Vincent Siles <vincent.siles@provenrun.com> - 2016-09-08 12:00 +0200

csiph-web