Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477619

[PATCH v3 3/6] staging: rtl8188eu: declare internal function as static

Show all headers | View raw

This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Geliang Tang <geliangtang@163.com>
Cc: Jakub Sitnicki <jsitnicki@gmail.com>
Cc: Ivan Safonov <insafonov@gmail.com>
Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org

---

Changes v2 -> v3:
- add "staging: " prefix to commit message title.

Changes v1 -> v2:
- improve the commit message.
---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 977bb25..1063617 100644
--- a/drivers/staging/rtl8188eu/core/rtw_recv.c
+++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
@@ -39,7 +39,7 @@ static u8 rtw_rfc1042_header[] = {
        0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
 };
 
-void rtw_signal_stat_timer_hdl(unsigned long data);
+static void rtw_signal_stat_timer_hdl(unsigned long data);
 
 void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 {
@@ -2088,7 +2088,7 @@ _recv_entry_drop:
 	return ret;
 }
 
-void rtw_signal_stat_timer_hdl(unsigned long data)
+static void rtw_signal_stat_timer_hdl(unsigned long data)
 {
 	struct adapter *adapter = (struct adapter *)data;
 	struct recv_priv *recvpriv = &adapter->recvpriv;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] staging: rtl8723au: remove unimplemented functions declaration Luca Ceresoli <luca@lucaceresoli.net> - 2016-09-06 18:40 +0200
  [PATCH v3 4/6] staging: rtl8188eu: remove rtw_proc_{init,remove}_one Luca Ceresoli <luca@lucaceresoli.net> - 2016-09-06 18:40 +0200
  [PATCH v3 5/6] staging: rtl8188eu: remove useless include Luca Ceresoli <luca@lucaceresoli.net> - 2016-09-06 18:40 +0200
  [PATCH v3 6/6] staging: rtl8188eu: remove unused debugging functions Luca Ceresoli <luca@lucaceresoli.net> - 2016-09-06 18:40 +0200
  [PATCH v3 2/6] staging: rtl8188eu: remove unimplemented functions declaration Luca Ceresoli <luca@lucaceresoli.net> - 2016-09-06 18:50 +0200
  [PATCH v3 3/6] staging: rtl8188eu: declare internal function as static Luca Ceresoli <luca@lucaceresoli.net> - 2016-09-06 18:50 +0200

csiph-web