Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1477095
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] nvme-rdma: fix null pointer dereference on req->mr |
| Date | 2016-09-06 08:30 +0200 |
| Message-ID | <sei3n-6DX-7@gated-at.bofh.it> (permalink) |
| References | <se40q-5xl-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Sep 05, 2016 at 04:24:38PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> If there is an error on req->mr, req->mr is set to null, however
> the following statement sets req->mr->need_inval causing a null
> pointer dereference. Fix this by bailing out to label 'out' to
> immediately return and hence skip over the offending null pointer
> dereference.
>
> Fixes: f5b7b559e1488 ("nvme-rdma: Get rid of duplicate variable")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] nvme-rdma: fix null pointer dereference on req->mr Colin King <colin.king@canonical.com> - 2016-09-05 17:30 +0200 Re: [PATCH] nvme-rdma: fix null pointer dereference on req->mr Christoph Hellwig <hch@infradead.org> - 2016-09-06 08:30 +0200 Re: [PATCH] nvme-rdma: fix null pointer dereference on req->mr Sagi Grimberg <sagi@grimberg.me> - 2016-09-06 11:40 +0200
csiph-web