Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support

From	"Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support
Date	2016-09-06 04:10 +0200
Message-ID	<sedZL-3RL-5@gated-at.bofh.it> (permalink)
References	<scraN-2Zr-3@gated-at.bofh.it> <scraO-2Zr-29@gated-at.bofh.it> <scylY-1an-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ricardo,

Ricardo Ribalda Delgado 於 2016/9/1 下午 07:22 寫道:
>>
>>         memcpy(pdata, &probe_data, sizeof(probe_data));
>> -       uart->port.rs485_config = fintek_8250_rs485_config;
>
> Maybe just:
>
>
> if (pdata->id != CHIP_ID_F81216)
>    uart->port.rs485_config = fintek_8250_rs485_config;
>
>
> Instead of the whole function
>
>>         uart->port.private_data = pdata;
>> +       fintek_8250_set_rs485_handler(uart);
>>
>>         return 0;
>>  }

Your comments is good for this patch. But we'll still try to add more 
SuperIO with this. So we'll separate it as a function to control
individually.

-- 
With Best Regards,
Peter Hong

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/7] serial: 8250_fintek: Add F81216 Support "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com> - 2016-09-01 05:50 +0200
  Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-09-01 13:30 +0200
    Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com> - 2016-09-06 04:10 +0200

csiph-web