Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478567

Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2

Show all headers | View raw

On Wed, Sep 7, 2016 at 11:36 AM, Kees Cook <keescook@chromium.org> wrote:
>
> - move page-spanning check behind a CONFIG since it's triggering false positives

Hmm. I pulled this, but looking at it I realized that

+       depends on !COMPILE_TEST

doesn't make any real sense to me.

All it does is make sure that "make allmodconfig" doesn't actually
test that the PAGESPAN code compiles.

It's not like that is a big cost for allmodconfig builds, but it does
mean that it gets less coverage.

And it really makes no sense to me. We *don't* want to run with that
option enabled normally.

I think what you actually meant was something like

+       depends on EXPERT

which means that it does *not* get enabled in normal user builds.

Hmm?

                  Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] usercopy fixes for v4.8-rc6-part2 Kees Cook <keescook@chromium.org> - 2016-09-07 20:40 +0200
  Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2 Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-07 21:20 +0200
    Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2 Kees Cook <keescook@chromium.org> - 2016-09-07 23:40 +0200
      Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2 Kees Cook <keescook@chromium.org> - 2016-09-07 23:50 +0200

csiph-web