Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field

From	hejianet <hejianet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field
Date	2016-09-07 04:40 +0200
Message-ID	<seAWm-2bR-3@gated-at.bofh.it> (permalink)
References	<seesN-4cL-1@gated-at.bofh.it> <senZ8-269-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marcelo

Thanks for the suggestion

Will consider that

B.R.

Jia


On 9/6/16 8:44 PM, Marcelo Ricardo Leitner wrote:
> On Tue, Sep 06, 2016 at 10:30:03AM +0800, Jia He wrote:
> ...
>> v2:
>> - 1/6 fix bug in udplite statistics.
>> - 1/6 snmp_seq_show is split into 2 parts
>>
>> Jia He (6):
>>    proc: Reduce cache miss in {snmp,netstat}_seq_show
>>    proc: Reduce cache miss in snmp6_seq_show
>>    proc: Reduce cache miss in sctp_snmp_seq_show
>>    proc: Reduce cache miss in xfrm_statistics_seq_show
>>    ipv6: Remove useless parameter in __snmp6_fill_statsdev
>>    net: Suppress the "Comparison to NULL could be written" warning
> Hi Jia,
>
> Did you try to come up with a generic interface for this, like
> snmp_fold_fields64() (note the fieldS) or snmp_fold_field64_batch() ?
>
> Sounds like we have the same code in several places and seems they all
> operate very similarly. They have a percpu table, an identified max, a
> destination buffer..
>
> If this is possible, this would reduce the possibility of hiccups in a
> particular code.
>
>    Marcelo
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
  [RFC PATCH v2 4/6] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
  [RFC PATCH v2 6/6] net: Suppress the "Comparison to NULL could be written" warning Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
  [RFC PATCH v2 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
    Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in  {snmp,netstat}_seq_show David Miller <davem@davemloft.net> - 2016-09-07 01:00 +0200
      Re: [RFC PATCH v2 1/6] proc: Reduce cache miss in  {snmp,netstat}_seq_show hejianet <hejianet@gmail.com> - 2016-09-07 04:30 +0200
  [RFC PATCH v2 5/6] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
  [RFC PATCH v2 2/6] proc: Reduce cache miss in snmp6_seq_show Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
  [RFC PATCH v2 3/6] proc: Reduce cache miss in sctp_snmp_seq_show Jia He <hejianet@gmail.com> - 2016-09-06 04:40 +0200
  Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-09-06 14:50 +0200
    Re: [RFC PATCH v2 0/6] Reduce cache miss for snmp_fold_field hejianet <hejianet@gmail.com> - 2016-09-07 04:40 +0200

csiph-web